Fix azure functions diagnostic logging #2433
Conversation
...in/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
fix-az-fn-diag-logger
branch
from
d3bfa21
to
88d424e
Compare
trask
force-pushed
the
fix-az-fn-diag-logger
branch
from
dfba9bf
to
53cc55c
Compare
|
This pull request fixes 1 alert when merging 53cc55c into 0385228 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 21121a8 into 0385228 - view on LGTM.com fixed alerts:
|
trask
force-pushed
the
fix-az-fn-diag-logger
branch
from
21121a8
to
edc0834
Compare
|
@heyams can you re-review? I've made several additional changes, thx |
|
This pull request fixes 1 alert when merging a82998e into 0385228 - view on LGTM.com fixed alerts:
|
...in/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
Outdated
Show resolved
Hide resolved
| @@ -126,7 +126,7 @@ public void onStartupSuccess() { | |||
| MDC.put(DiagnosticsHelper.MDC_PROP_OPERATION, "Startup"); | |||
| try (MDC.MDCCloseable ignored = INITIALIZATION_SUCCESS.makeActive()) { | |||
| LoggerFactory.getLogger(DiagnosticsHelper.DIAGNOSTICS_LOGGER_NAME) | |||
There was a problem hiding this comment.
static final diagnostics logger?
There was a problem hiding this comment.
we can't here because it would trigger the logger to be initialized too early
| @Nullable String statsbeatEndpoint) { | ||
|
|
||
| if (Strings.isNullOrEmpty(connectionString)) { | ||
| this.connectionString = null; |
There was a problem hiding this comment.
is it necessary to set it to null?
if (!Strings.isNullOrEmpty(conenctionString)) {
}
There was a problem hiding this comment.
I think this is helpful because we have a couple of places that get the connection string / ikey, and then those won't get outdated ones (Azure Spring Cloud can set the connection string to null at runtime)
| if (Strings.isNullOrEmpty(connectionString)) { | ||
| this.connectionString = null; | ||
| this.statsbeatConnectionString = null; | ||
| } else { |
There was a problem hiding this comment.
| if (Strings.isNullOrEmpty(connectionString)) { | |
| this.connectionString = null; | |
| this.statsbeatConnectionString = null; | |
| } else { | |
| if (!Strings.isNullOrEmpty(connectionString)) { |
|
This pull request fixes 1 alert when merging 76bbf86 into 1f6f3b5 - view on LGTM.com fixed alerts:
|
No description provided.