Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 18 to test matrix #2391

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Add Java 18 to test matrix #2391

merged 6 commits into from
Jul 20, 2022

Conversation

trask
Copy link
Member

@trask trask commented Jul 13, 2022

No description provided.

@jeanbisutti
Copy link
Member

c796163 commit removes asm transitive dependencies from the agent project: ./gradlew :agent:agent:dependencies => no asm dependency. When the agent is packaged and used for this commit, an asm version that does not support java 18 is still in use (this version is ok until Java 17). Open telemetry java agent 1.15.0 uses an asm version that works until Java 19.

@trask
Copy link
Member Author

trask commented Jul 19, 2022

I saw the issue below earlier with Java 17, some weird incompatibility between log4j 1.2 MDC and Java 17 (I don't think I ever tracked it down), but then the issue went away in later Java 17 releases, I'm guessing they made some fix/accommodation in the JDK, see https://github.com/microsoft/ApplicationInsights-Java/pull/1920/files#diff-c6a2e6bfb7c1b49dd897a039b659bdb53acd65dfddef05473a1dc98d90b23f8d

TraceLog4j12Test$Tomcat8Java18Test > testTraceLog4j1_2WithExeption() FAILED
    java.lang.AssertionError: 
    Expecting map:
      {"Logger Message"="This is an exception!", "LoggerName"="smoketestapp", "SourceType"="Logger", "ThreadName"="http-nio-8080-exec-2"}
    to contain entries:
      ["MDC key"="MDC value"]
    but could not find the following map entries:
      ["MDC key"="MDC value"]

@trask trask marked this pull request as ready for review July 20, 2022 16:35
@trask trask requested a review from jeanbisutti as a code owner July 20, 2022 16:35
@trask trask merged commit 60414b2 into main Jul 20, 2022
@trask trask deleted the java18 branch July 20, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants