Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop LoggingLevel #2254

Merged
merged 7 commits into from
May 3, 2022
Merged

Drop LoggingLevel #2254

merged 7 commits into from
May 3, 2022

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Apr 29, 2022

No description provided.

@heyams heyams marked this pull request as ready for review April 29, 2022 23:24
@heyams heyams requested a review from trask as a code owner April 29, 2022 23:24
trask
trask reviewed May 2, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add configuration setting to opt-in and preserve existing behavior

@heyams
Copy link
Contributor Author

heyams commented May 2, 2022

let's also add configuration setting to opt-in and preserve existing behavior

i thought we're not going to make this opt-in. we will update the doc to introduce this breaking change. function will send loglevel and keeping logginglevel will be more confusing to customers? did i miss something else?

@heyams heyams merged commit a105c16 into vnext May 3, 2022
@heyams heyams deleted the heya/drop-loggingLevel branch May 3, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyams @trask