Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off Statsbeat when proxy is used or any exception from the server #2221

Merged
merged 17 commits into from
Apr 13, 2022
Merged

Turn off Statsbeat when proxy is used or any exception from the server #2221

merged 17 commits into from
Apr 13, 2022

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Apr 7, 2022

No description provided.

@heyams heyams requested a review from trask as a code owner April 7, 2022 19:53
trask
trask approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask self-requested a review April 8, 2022 20:37
hectorhdzg
hectorhdzg approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trask
Copy link
Member

trask commented Apr 9, 2022

@heyams @hectorhdzg I pushed some changes:

  • suppress all logging of statsbeat telemetry failures (introduced a noop logger to make this easier, there were many additional places that would have needed to be wrapped in conditionals)
  • if statsbeat is shut down, then stop sending statsbeat telemetry from disk (which will likely keep failing and getting stored back to disk every 30 seconds until they expire after 2 days)
  • shut down statsbeat if the first X statsbeat ingestions requests all fail for any reason other than throttling (439/402), and removed the special case for http proxy
    • I believe this is both simpler than special casing for http proxy, and will cover potentially other unknown environmental limitations that we may be unaware of currently

@heyams
Copy link
Contributor Author

heyams commented Apr 13, 2022

Approved.

@trask trask merged commit 9361d1d into main Apr 13, 2022
@trask trask deleted the heya/fix-statsbeat branch April 13, 2022 03:42
trask added a commit that referenced this pull request Apr 14, 2022
@trask @heyams
Merge main into vnext (#2228)
f9f7651 
* Add scheduled delay for batch span processor (#2222)

* Turn off Statsbeat when proxy is used or any exception from the server (#2221)

* Turn off statsbeat when proxy used or any exception from the server

* Fix comment format

* Add a todo

* Address feedback

* Change todo

* Shut down after 3 statsbeat errors

* Reset statsbeat error count on success

* Use one time success flag and increment max to 10

* No need to reset

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Suppress statbeat error logging

* Simplify and avoid other unknown cases

* move and comment

* one more logging

* Update to latest spec PR

* imports

* Add comment

* Add TODO

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Release 3.2.11 (#2227)

* Prepare for the new release

* Reword

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* spotless

* update

Co-authored-by: Helen <56097766+heyams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@ramthi ramthi ramthi left review comments

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyams @trask @ramthi @hectorhdzg