Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URI parse error #2067

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Fix URI parse error #2067

merged 3 commits into from
Jan 24, 2022

Conversation

trask
Copy link
Member

@trask trask commented Jan 22, 2022

Fixes this error

WARN c.m.a.a.internal.exporter.Exporter - Parsing http.url: Illegal character in query at index 167: REDACTED
at java.net.URI$Parser.fail(URI.java:2845)
at java.net.URI$Parser.checkChars(URI.java:3018)
at java.net.URI$Parser.parseHierarchical(URI.java:3108)
at java.net.URI$Parser.parse(URI.java:3050)
at java.net.URI.<init>(URI.java:588)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.getTargetForHttpClientSpan(Exporter.java:546)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.applyHttpClientSpan(Exporter.java:479)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.applySemanticConventions(Exporter.java:324)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.exportRemoteDependency(Exporter.java:272)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.internalExport(Exporter.java:221)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.export(Exporter.java:177)
at io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.exportCurrentBatch(BatchSpanProcessor.java:305)
at io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.run(BatchSpanProcessor.java:222)
at java.lang.Thread.run(Thread.java:748)


import org.junit.jupiter.api.Test;

public class UrlParserTargetTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both urlparserapthtest and urlparsertargettest.java?

we can just update urlparsertest.java?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that file was getting really long, i thought it helped to break it out into two separate tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

@trask trask merged commit 19713f1 into main Jan 24, 2022
@trask trask deleted the fix-parse-error branch January 24, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants