Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friendly exception for cipher suite issue #2053

Merged
merged 15 commits into from
Jan 25, 2022
Merged

Friendly exception for cipher suite issue #2053

merged 15 commits into from
Jan 25, 2022

Conversation

kryalama
Copy link
Contributor

@kryalama kryalama commented Jan 14, 2022 •
edited
Loading

No description provided.

@kryalama
Copy link
Contributor Author

kryalama commented Jan 14, 2022 •
edited
Loading

Sample:

ApplicationInsights Java Agent failed to connect to Live metric end point.

Description:
Probable root cause may be : missing cipher suites which are expected by the requested target.

Action:
The Application Insights Java agent detects that you do not have any of the following cipher suites that are supported by the endpoint it connects to: https://rt.services.visualstudio.com/QuickPulseService.svc
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
Learn more about troubleshooting this network issue related to cipher suites here: https://go.microsoft.com/fwlink/?linkid=2185426

Note:
This message is only logged the first time it occurs after startup.

@heyams
Copy link
Contributor

heyams commented Jan 14, 2022 •
edited
Loading

can we add tests if possible?

@kryalama kryalama requested review from trask and heyams January 18, 2022 22:28
@kryalama kryalama requested a review from trask January 20, 2022 00:15
kryalama and others added 3 commits January 19, 2022 22:42
@kryalama @trask
Update agent/agent-tooling/src/main/java/com/microsoft/applicationins…
0a3c0e8 
…ights/agent/internal/common/NetworkFriendlyExceptions.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@kryalama
handle sslhandshaketimeout exception and update missing ciphers message
260cd5d
@kryalama
handle merge conflicts
f638196
@kryalama kryalama requested a review from trask January 20, 2022 23:43
@kryalama kryalama requested a review from trask January 25, 2022 00:02
@kryalama kryalama requested a review from heyams January 25, 2022 17:33
@kryalama kryalama merged commit 085857f into main Jan 25, 2022
@kryalama kryalama deleted the kryalama/friendlyupdate branch January 25, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@heyams heyams Awaiting requested review from heyams heyams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kryalama @heyams @trask