Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status exception in a readonly file system #1967

Merged
merged 19 commits into from
Nov 30, 2021
Merged

Fix status exception in a readonly file system #1967

merged 19 commits into from
Nov 30, 2021

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Nov 17, 2021

No description provided.

@heyams heyams marked this pull request as ready for review November 18, 2021 22:03
@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2021

This pull request introduces 1 alert when merging 68812bd into 7ee4e80 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

trask
trask approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question above

@heyams @trask
Fix negation
7bb5451 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@heyams heyams merged commit dcbb00b into main Nov 30, 2021
@heyams heyams deleted the heya/fix-status branch November 30, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@kryalama kryalama Awaiting requested review from kryalama

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyams @trask