Reduce netty pool size #1944
Merged
Reduce netty pool size #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
Nov 2, 2021
|
|
||
| public class LazyHttpClient implements HttpClient { | ||
|
|
||
| private static final String APPLICATIONINSIGHTS_AUTHENTICATION_SCOPE = | ||
| "https://monitor.azure.com//.default"; | ||
|
|
||
| private static final HttpClient INSTANCE = new LazyHttpClient(); | ||
| private static final int DEFAULT_MAX_TOTAL_CONNECTIONS = 200; |
There was a problem hiding this comment.
200 to 1? what is the motivation?
There was a problem hiding this comment.
200 is a different number, I don't think we need a non-default value for that.
1 is the number of threads (down from default which is based on cpu-count).
the motivation is in the comment below (to reduce memory consumption, which was a regression in 3.2.0 when we switched http clients)
heyams
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attaching snapshot for testing: applicationinsights-agent-3.2.3-BETA-SNAPSHOT.jar.zip