Support system properties for the main "coordinates" #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
Jul 26, 2021
| @@ -446,23 +459,48 @@ private static String getWebsiteSiteNameEnvVar() { | |||
| return value; | |||
| } | |||
|
|
|||
| public static String overlayWithSysPropEnvVar( | |||
| String systemPropertyName, String envVarName, String defaultValue) { | |||
| String value = getSystemProperty(systemPropertyName); | |||
There was a problem hiding this comment.
system properties have a higher precedence over env vars? should it be the other way around? env vars are user defined properties and i think it has a higher precedence over the default system properties, right? we do want to respect end user's choice?
There was a problem hiding this comment.
system properties are also provided by end user
this precedence ordering is same as Spring (and OTel also follows same):
https://docs.spring.io/spring-boot/docs/2.5.2/reference/html/features.html#features.external-config
heyams
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1684
Supports system properties for the main "coordinates":
Also logs warning if using undocumented
APPLICATIONINSIGHTS_JMX_METRICS(planning to remove support for this undocumented env var in the future).Also renames
APPLICATIONINSIGHTS_PROFILER_ENABLEDtoAPPLICATIONINSIGHTS_PREVIEW_PROFILER_ENABLED(cc: @johnoliver).