-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate exception telemetry's parsedStack when there is a deep stack trace exceeding 65536 bytes #1702
Conversation
can you test with an exception that is captured by auto-instrumentation? I think that will go through a different code path and not get fixed by this change |
Breeze accepts exceptions captured by auto-instrumentation that exceed 65536 bytes. I've sent an email to Oleg to confirm if that's a bug.. because of it's insistent. here clearly indicates that both parsedStack and stack should have the same constraint.. but based on my testing, "stack" doesn't have this constraint. that's why it doesn't have any impact on auto-instrumentation yet. |
core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java
Show resolved
Hide resolved
@trask test:smoke:testApps:WebFlux kept failing.. i reran the job once.. i will let you take a look.. this is keep coming back. |
… trace exceeding 65536 bytes (#1702) * Repro deep stack trace * Truncate parsedStack not to exceed 65536 bytes capacity * Remove test code * cleanup unused imports * Fix javadoc * add note Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
applicationinsights-agent-3.1.1-BETA-SNAPSHOT.zip
2021-05-20 17:44:13.245-07 DEBUG c.m.applicationinsights.agent - ############# current stack depth: 8943
2021-05-20 17:44:13.266-07 DEBUG c.m.a.telemetry.ExceptionTelemetry - parsedStack is exceeding 65536 bytes capacity. It is truncated from full 1024 frames to partial 308 frames.
@trask method call depth (8943) does not equal to the number of stack frames (total 1024). What i showed you earlier in Fiddler is the full stack.
When we add stack frame to ExceptionTelemetry, it's already in the reversed order.
Fix #482