Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backoff retries #1253

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fix backoff retries #1253

merged 2 commits into from
Jun 4, 2020

Conversation

trask
Copy link
Member

@trask trask commented Jun 4, 2020

No description provided.

@trask trask requested a review from littleaj June 4, 2020 05:56
@trask trask marked this pull request as ready for review June 4, 2020 05:56
@trask trask force-pushed the trask/fix-backoff-retries branch from 104d9f5 to 6ed8f35 Compare June 4, 2020 19:05
@trask trask force-pushed the trask/fix-backoff-retries branch from 6ed8f35 to 3830733 Compare June 4, 2020 19:25
littleaj
littleaj approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@littleaj littleaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward, though I wonder if we are now missing tests for the backoff code.

@trask
Copy link
Member Author

trask commented Jun 4, 2020

Seems straightforward, though I wonder if we are now missing tests for the backoff code.

Unfortunately we were already missing tests for the backoff code. The tests I removed were testing code that has not been used for a long time 😕.

@trask trask merged commit 2319268 into master Jun 4, 2020
@trask trask deleted the trask/fix-backoff-retries branch June 4, 2020 22:52
trask pushed a commit that referenced this pull request Oct 17, 2020
@pavolloffay
Support otlp_span and otelp_metric exporter config names (#1253)
8ed4ef5 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littleaj littleaj littleaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @littleaj