Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown issue due to non-daemon thread #1245

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

trask
Copy link
Member

@trask trask commented May 24, 2020

For short-running applications that never perform a GC, this non-daemon thread used during startup is never collected and prevents normal termination at the end of the main method.

@trask trask marked this pull request as ready for review May 24, 2020 00:16
@trask trask force-pushed the trask/fix-shutdown-issue branch from 849895c to 8ad7d5d Compare May 24, 2020 00:20
Copy link
Contributor

@littleaj littleaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@trask trask merged commit bd323f0 into master May 26, 2020
@trask trask deleted the trask/fix-shutdown-issue branch May 26, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants