Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs from static analysis #1177

Merged
merged 11 commits into from
Dec 13, 2019
Merged

Fix bugs from static analysis #1177

merged 11 commits into from
Dec 13, 2019

Conversation

littleaj
Copy link
Contributor

Bugs found by lgtm.com

@littleaj littleaj requested a review from trask December 12, 2019 19:03
@lgtm-com
Copy link

lgtm-com bot commented Dec 12, 2019

This pull request fixes 14 alerts when merging 1179acd into 09823c3 - view on LGTM.com

fixed alerts:

  • 4 for Result of multiplication cast to wider type
  • 3 for Missing space in string literal
  • 2 for Useless null check
  • 1 for Inconsistent synchronization of getter and setter
  • 1 for Dereferenced variable may be null
  • 1 for Boxed variable is never null
  • 1 for Race condition in double-checked locking object initialization
  • 1 for Potential input resource leak

trask
trask reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments/questions below

...a/com/microsoft/applicationinsights/internal/channel/common/SenderThreadsBackOffManager.java Outdated Show resolved Hide resolved
.../com/microsoft/applicationinsights/internal/channel/common/TransmissionFileSystemOutput.java Outdated Show resolved Hide resolved
.../com/microsoft/applicationinsights/internal/channel/common/TransmissionFileSystemOutput.java Outdated Show resolved Hide resolved
littleaj and others added 3 commits December 12, 2019 15:10
@littleaj @trask
Apply suggestions from code review
a8cb644 
Remove redundant casts

Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
@littleaj
inline unnecessary local variable
81e051a
@littleaj
fix error message typos
8af89c3
@lgtm-com
Copy link

lgtm-com bot commented Dec 12, 2019

This pull request fixes 14 alerts when merging 8af89c3 into 58b944e - view on LGTM.com

fixed alerts:

  • 4 for Result of multiplication cast to wider type
  • 3 for Missing space in string literal
  • 2 for Useless null check
  • 1 for Inconsistent synchronization of getter and setter
  • 1 for Dereferenced variable may be null
  • 1 for Boxed variable is never null
  • 1 for Race condition in double-checked locking object initialization
  • 1 for Potential input resource leak

@littleaj littleaj merged commit c243b86 into master Dec 13, 2019
@littleaj littleaj deleted the littleaj/lgtm_fixes branch December 13, 2019 00:10
trask pushed a commit that referenced this pull request Sep 21, 2020
Fix a bug when FieldBackedProvider uses a map and value is set to null (
70a06ef 
#1177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littleaj @trask