Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async thread tracking #1100

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix async thread tracking #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ain/java/com/microsoft/applicationinsights/agent/internal/model/AuxThreadContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ public Span startAndMarkAsyncTransactionComplete() {
private Span start(boolean completeAsyncTransaction) {
ThreadContextThreadLocal.Holder threadContextHolder = Global.getThreadContextHolder();
ThreadContextPlus threadContext = threadContextHolder.get();
if (threadContext != null) {
// TODO once local spans are supported, only return NOP if parent spans are the same
// Checking if in same request is needed in case the existing thread context is from a prior request
// (e.g. this can happen if the thread activity was captured via Thread constructor, but the thread was
// really then used in a thread pool)
if (threadContext != null && threadContext.getServletRequestInfo() == servletRequestInfo) {
if (completeAsyncTransaction) {
threadContext.setTransactionAsyncComplete();
}
Expand Down