Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reworked uuid tostring #1001

Merged
merged 2 commits into from
Jul 31, 2019
Merged

reworked uuid tostring #1001

merged 2 commits into from
Jul 31, 2019

Conversation

littleaj
Copy link
Contributor

Fix #910

@littleaj littleaj added this to the 2.4.1 milestone Jul 31, 2019
@littleaj littleaj requested a review from trask July 31, 2019 17:55
trask
trask approved these changes Jul 31, 2019
View reviewed changes
...m/microsoft/applicationinsights/web/internal/correlation/TelemetryCorrelationUtilsTests.java
@@ -771,6 +774,13 @@ public void testRequestContextIsNotResolvedWithNullRequestTelemetry() {
Assert.assertNull(requestTelemetry.getSource());
}

@Test
public void testLeadingZerosGuid() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@littleaj littleaj mentioned this pull request Jul 31, 2019
Closed
@littleaj littleaj merged commit e156fad into release_2.4.1 Jul 31, 2019
@littleaj littleaj deleted the fix_traceid_string branch July 31, 2019 20:25
@littleaj littleaj restored the fix_traceid_string branch July 31, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@littleaj @trask