Merge pull request #1012 from microsoft/agent-diagnostic-logging

Better agent diagnostic logging
microsoft · Aug 20, 2019 · a811128 · a811128
2 parents 9fa1282 + b78f163
commit a811128
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/agent/src/main/java/com/microsoft/applicationinsights/agent/internal/MainEntryPoint.java b/agent/src/main/java/com/microsoft/applicationinsights/agent/internal/MainEntryPoint.java
@@ -47,7 +47,9 @@ private MainEntryPoint() {
     public static void premain(Instrumentation instrumentation, File agentJarFile) {
         try {
             startupLogger = initLogging(instrumentation, agentJarFile);
+            startupLogger.info("ApplicationInsights agent starting...");
             start(instrumentation, agentJarFile);
+            startupLogger.info("ApplicationInsights agent started");
         } catch (ThreadDeath td) {
             throw td;
         } catch (Throwable t) {

diff --git a/agent/src/main/resources/ai.logback.xml b/agent/src/main/resources/ai.logback.xml
@@ -6,9 +6,7 @@
       <pattern>%d{yyyy-MM-dd HH:mm:ss.SSS} %-5level %logger{36} - %msg%n</pattern>
     </encoder>
   </appender>
-  <logger name="org.glowroot.instrumentation" level="info" />
-  <logger name="com.microsoft.applicationinsights.agent.shadow" level="warn" />
-  <root level="info">
+  <root level="${applicationInsights.agent.logging.level:-error}">
     <appender-ref ref="CONSOLE" />
   </root>
 </configuration>
diff --git a/...rc/main/java/com/microsoft/applicationinsights/web/internal/WebRequestTrackingFilter.java b/...rc/main/java/com/microsoft/applicationinsights/web/internal/WebRequestTrackingFilter.java
@@ -189,12 +189,14 @@ public void init(FilterConfig config) {
             handler = new HttpServerHandler(new ApplicationInsightsServletExtractor(), webModulesContainer,
                                                 cleaners, telemetryClient);
             if (AgentBridgeFactory.isAgentAvailable()) {
+                InternalLogger.INSTANCE.info("Agent is running");
                 agentBridge = AgentBridgeFactory.create(new SdkBridgeFactory() {
                     public SdkBridge create() {
                         return new SdkBridgeImpl(telemetryClient);
                     }
                 });
             } else {
+                InternalLogger.INSTANCE.info("Agent is not running");
                 agentBridge = AgentBridgeFactory.create();
             }
             if (StringUtils.isNotEmpty(config.getFilterName())) {