Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Main][Task]29884493: Add a Function to Export Offline Listener From Sender #2434

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[Main][Task]29884493: Add a Function to Export Offline Listener From Sender #2434

merged 1 commit into from
Oct 15, 2024

Conversation

Karlie-777
Copy link
Contributor

No description provided.

@Karlie-777 Karlie-777 mentioned this pull request Oct 15, 2024
Open
MSNev
MSNev approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@MSNev MSNev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This wasn't actually a "bug" as previously this was just all internal as it only listened to the browser "online" state.

Now that we have extended the IOfflineListener to have the "user" state this makes sense.

@Karlie-777 Karlie-777 merged commit afb1db7 into main Oct 15, 2024
7 checks passed
@MSNev MSNev added this to the 3.3.4 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSNev MSNev MSNev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Karlie-777 @MSNev