Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alm Toolkit: version 5.1.3 doesn't open files using relative paths anymore #307

Open
samusaran opened this issue Oct 28, 2024 · 3 comments

Comments

@samusaran
Copy link

samusaran commented Oct 28, 2024

We currently have for every Model.bim in our codebase, one or more associated almt files.

Since this code is committed and everyone may have cloned this code in a different path, all almt files point to ".\Model.bim", since the almt file is always in the same folder as the bim file.

This doesn't work since 5.1.3, I guess because something broke the relative path compatibility. The model.bim get's opened just fine with the absolute path, which reset basically everything in the almt file (like ignored items) and it defeats the purpose of having the almt file altogether.

I think this is a breaking change for everyone that have a similar setup.

How to reproduce:

  • create a model.bim
  • create an almt file in the same folder pointing to "./Model.bim"
  • open the almt file by double clicking on it
  • the comparison can't open the file on 5.1.3, but it can on previous versions

It may have something to do with this: 2f3120d#diff-f233c801c535a35168538436af54ce5d8b40df38288c7d108ca1a0ae8c0e1bc6R67

Thank you

@christianwade
Copy link
Member

Hi Alessandro, thank you for raising this and also the reference to the line of code 😀

Can you please try this pre-release and see if it works? I'll let you use if for a while before doing a full release so we know it works well and also I have to jump through hoops for digital signing for full releases nowadays.

Please also download the MSI and let me know when you have it because I want to remove the pre-release.

https://github.com/microsoft/Analysis-Services/releases/tag/5.1.4-PreRelease

Thanks,
Christian

christianwade added a commit that referenced this issue Oct 31, 2024
@samusaran
Copy link
Author

Hi Christian, relative paths seems to be working correctly as before using the 5.1.4.

Thank you,
Alessandro

@christianwade
Copy link
Member

Good news. I'll remove the prebuild version shortly. The next full release (when I get to it) will include this fix.
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants