[UWP] Add new property to the renderer to remove margins from selectAction #8806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-dingler
commented
Jan 29, 2024
anna-dingler
requested review from
krschau,
beervoley,
jwoo-msft and
paulcam206
and removed request for
krschau
anna-dingler
commented
Jan 29, 2024
jwoo-msft
reviewed
Jan 29, 2024
jwoo-msft
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
https://dev.azure.com/microsoft/OS/_workitems/edit/46854074/
Description
For selectAction, we add an additional margin to the button. This causes the hover state to have two different colors, and it looks overdrawn.
To resolve this, I added a boolean to the renderer
AddSelectActionMarginthat will determine if we should add the additional margin. The boolean defaults totrue.Sample Card
N/A
How Verified
Verified manually with the visualizer.