[UWP Renderer] Do not wrap textblock in ComboBoxItem for compact choiceset #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run ios-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #7828
Description
Per the documentation, "Items added to the ComboBox are wrapped in ComboBoxItem containers.".
Since we were already wrapping the provided TextBlocks in ComboBoxItems before adding them to the ComboBox control, the items were wrapped twice, and Narrator did not handle this behavior correctly.
Adding TextBlocks to the ComboBox directly fixes this issue, and Narrator will announce "Snooze for 5 minutes ComboBox collapsed" as expected.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Scenarios/CalendarReminder.json
How Verified
Verified manually on the UWP Visualizer.
Microsoft Reviewers: Open in CodeFlow