-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS][Renderer] Input.Number.value as string in Action.Submit #5134
Conversation
@@ -11,7 +11,7 @@ | |||
"start": "hexo server" | |||
}, | |||
"hexo": { | |||
"version": "5.2.0" | |||
"version": "4.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think you meant to change this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't, but then help me understand how it happened - I litterally just compiled (npx lerna run build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure really -- might be something hexo modified when you were testing your changes?
@@ -3983,7 +3983,7 @@ export class SubmitAction extends Action { | |||
let input = inputs[key]; | |||
|
|||
if (input.id) { | |||
this._processedData[input.id] = input.value; | |||
this._processedData[input.id] = typeof input.value === "string" ? input.value : input.value.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the package.json
update! changes look good
Related Issue
Fixes #5111
Description
Reverts to emitting Input.Number.value as a string in an Action.Submit.data
Sample Card
How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow