Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated default value #4907

Merged
merged 2 commits into from
Oct 21, 2020
Merged

updated default value #4907

merged 2 commits into from
Oct 21, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 10, 2020

Related Issue

Fixed #4838

Description

Changed the default value in XIB, so users wouldn't have to. Teams can't change XIB ATM, so made this change to our XIB.
There are no impacts to other customers. This change changed the visibility of the error messages of the input to the collapsed state. Once input is loaded from XIB, the error message label's visibility is set to collapsed by the renderers and overrides any values in XIB.

How Verified

How you verified the fix, including one or all of the following:

  1. Change is verified that worked for Team
  2. Regression Test is done and verified.
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Oct 17, 2020
@ghost ghost assigned paulcam206 Oct 17, 2020
@ghost
Copy link

ghost commented Oct 17, 2020

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@jwoo-msft jwoo-msft requested a review from almedina-ms October 21, 2020 18:24
@ghost ghost removed the no-recent-activity label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Hi @jwoo-msft; Thanks for taking action on your previously stale pull request. Resetting staleness.

@jwoo-msft jwoo-msft merged commit cba2221 into main Oct 21, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-default-value-update branch October 21, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Input Evolution] [input validation error messages enabled on the card sent by bot]
3 participants