[WPF] Change TextBlock to render only when text is not empty #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
approved these changes
Sep 22, 2020
jwoo-msft
added a commit
that referenced
this pull request
Sep 29, 2020
* work in progress * updated ChoiceSetInput.cpp * changed the code such that missing text doesn't throw exception * updated TextBlock Test * uwp changes * android changes * Updated Shared Model to include parse warnings * [WPF] Change TextBlock to render only when text is not empty (#4799) * Change default value and change rendering behavior * Add skip to failing test * perf investigation * investigation changes * Updated Default Value Handling * Updated app to have explicit render button * changed the code such that missing text doesn't throw exception * updated TextBlock Test * uwp changes * android changes * Updated Shared Model to include parse warnings * more changes * Android Changes * work in progress * FactSet for dotnet * ios change * Remove warnings for elements that failed to render and don't perform fallback on them * addressed CR review comments * Updated dotnet Additional Properties Handling (#4800) * perf investigation * investigation changes * Updated Default Value Handling * Updated app to have explicit render button * reverted button changes * addressed review comments * removed FactSet.Test.json to include comprehensive cards from a new PR * Removed TextBlock.Test.json for udpated card which will be added in separate PR * updated idl * updated factset test Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Alberto Medina Gutierrez <almedina@microsoft.com>
|
🎉 Handy links: |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* work in progress * updated ChoiceSetInput.cpp * changed the code such that missing text doesn't throw exception * updated TextBlock Test * uwp changes * android changes * Updated Shared Model to include parse warnings * [WPF] Change TextBlock to render only when text is not empty (microsoft#4799) * Change default value and change rendering behavior * Add skip to failing test * perf investigation * investigation changes * Updated Default Value Handling * Updated app to have explicit render button * changed the code such that missing text doesn't throw exception * updated TextBlock Test * uwp changes * android changes * Updated Shared Model to include parse warnings * more changes * Android Changes * work in progress * FactSet for dotnet * ios change * Remove warnings for elements that failed to render and don't perform fallback on them * addressed CR review comments * Updated dotnet Additional Properties Handling (microsoft#4800) * perf investigation * investigation changes * Updated Default Value Handling * Updated app to have explicit render button * reverted button changes * addressed review comments * removed FactSet.Test.json to include comprehensive cards from a new PR * Removed TextBlock.Test.json for udpated card which will be added in separate PR * updated idl * updated factset test Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Alberto Medina Gutierrez <almedina@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
references #4478
Description
Updated WPF renderer to render a textblock only when text is given
How Verified
The fix was verified manually, as in WPF we don't raise parsing errors, then it's a rendering only fix
Microsoft Reviewers: Open in CodeFlow