Updated Bleed for iOS

[jwoo-msft]

Related Issue

Fixed #4745

Description

Setting the constraint with superview for bleed resulted in dependency on the superview. The fix limited the use of constraint to superview. Made explicit reference to the superview for code maintenance.

How Verified

1. Updated Bleed.Comprehensive.json to include a container with bleed in a showcard.
2. Ran regression tests, and verified the fix

Microsoft Reviewers: Open in CodeFlow

[shalinijoshi19]

@jwoo-msft this might need to be ported to release/1.2 - let's confirm with the Teams mobile team tonight. Thanks!

[shalinijoshi19]

Is this just an iOS issue? @RebeccaAnne should have a peek here too !

[RebeccaAnne]

Is this just an iOS issue? @RebeccaAnne should have a peek here too !

I'm not fully grokking the nuance of these changes, but the crash from the bug looks like an iOS specific concern.

That said, I ran the bug payload through UWP, .NET, and JavaScript, and it doesn't look like it's rendering quite the same on all platforms. UWP seems to bleed the show card into the show card padding, whereas the other two don't. @jwoo-msft what is this card supposed to look like?

UWP (note no emphasis padding around the show card):

JavaScript (emphasis border around the show card) (.NET is similar):

[jwoo-msft]

Is this just an iOS issue? @RebeccaAnne should have a peek here too !

I'm not fully grokking the nuance of these changes, but the crash from the bug looks like an iOS specific concern.

That said, I ran the bug payload through UWP, .NET, and JavaScript, and it doesn't look like it's rendering quite the same on all platforms. UWP seems to bleed the show card into the show card padding, whereas the other two don't. @jwoo-msft what is this card supposed to look like?

The card above can be condensed to the below. FYI, I added the snippet of this card to our Bleed.Comprehenisve.json.

		{
			"type":"TextBlock",
			"text":"REMOVED TEXT",
			"size":"ExtraLarge",
			"weight":"Bolder",
			"wrap":true
		},
		{
			"type":"ActionSet",
			"actions":[
			{
				"type":"Action.ShowCard",
				"title":"Results",
				"card":{
					"type":"AdaptiveCard",
					"$schema":"http://adaptivecards.io/schemas/adaptive-card.json",
					"body":[
					{
						"type":"Container",
						"items":[
							{
								"type":"Container",
								"items":[
								{
									"type":"TextBlock",
									"text":"REMOVED TEXT",
									"fontType":"Default",
									"size":"ExtraLarge",
									"spacing":"None",
									"weight":"Bolder",
									"wrap":true
								}
								],
								"style":"default"
							}
						],
						"style":"emphasis",
						"bleed":true
					}
					]
				}
			}
		]
		}

ActionSet ShowCard -> Container with emphasis style with bleed true -> Container with default style.
I don't think we have specified the bleed for showcard in ActionSet. If the parent card has a default style, then letting the container with emphasis to bleed is a possibility.