[HostConfig Schema] Update Host Config schema to reflect changes made for input validation #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for input validation
2 tasks
added 7 commits
August 12, 2020 16:37
almedina-ms
reviewed
Aug 25, 2020
samples/HostConfig/sample.json
Outdated
| @@ -273,7 +273,6 @@ | |||
| { | |||
| "label": | |||
| { | |||
| "inputSpacing": "small", | |||
There was a problem hiding this comment.
why is the removals of inputSpacing here and in source/uwp/Visualizer/HostConfigs/DefaultHostConfig.json being done? #Resolved
There was a problem hiding this comment.
almedina-ms
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Part one of fix for #4580. (Doc changes to come later)
Description
Updated the host config schema to include the changes made for input validation in 1.3. Also updated sample host configs that were not following the schema.
Microsoft Reviewers: Open in CodeFlow