[JS] Prevent factsets from presenting as tables for accessibility #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
paulcam206
added
Area-Accessibility
|
/azp run |
|
No pipelines are associated with this pull request. |
dclaux
approved these changes
Jun 5, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
VSO #23950960
Description
We build factsets in JS using a
<table>. However, this has semantic meaning for screenreaders, which causes factsets to be read awkwardly. The fix (as recommended) is to setrole="presentation"on the<table>element. This does not cause the screenreader to skip the content (as the child elements have noroleset), but does cause it to treat the content normally.How Verified
Microsoft Reviewers: Open in CodeFlow