Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] GetResourceUris API #1759

Merged
merged 3 commits into from
Aug 3, 2018

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Aug 2, 2018

Add the GetResources API to android

Solves this: #1658

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -139,7 +141,6 @@ struct tm {
%shared_ptr(AdaptiveCards::SubmitActionParser)
%shared_ptr(AdaptiveCards::ImageSetParser)
%shared_ptr(AdaptiveCards::DateInputParser)
%shared_ptr(AdaptiveCards::DateTimePreparsedToken)
Copy link
Contributor

@RebeccaAnne RebeccaAnne Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

) [](start = 49, length = 1)

Why are we removing this? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont even know how did this happen, reverting this deletion


In reply to: 207609313 [](ancestors = 207609313)

Copy link
Contributor

@RebeccaAnne RebeccaAnne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@almedina-ms almedina-ms merged commit e728d26 into master Aug 3, 2018
@almedina-ms almedina-ms deleted the user/almedina-ms/AndroidGetResourceUris branch August 6, 2018 21:05
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Add remote resource information header to swig file

* Add RemoteResourceInformationVector swig generation

* Unmaking the DateTimePreparsedToken deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants