Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample Cards] Text in sample cards truncated #4712

Closed
jwoo-msft opened this issue Sep 1, 2020 · 4 comments · Fixed by #4793
Closed

[Sample Cards] Text in sample cards truncated #4712

jwoo-msft opened this issue Sep 1, 2020 · 4 comments · Fixed by #4793
Assignees
Labels
Area-Samples Fixes related to our test samples Bug
Milestone

Comments

@jwoo-msft
Copy link
Member

jwoo-msft commented Sep 1, 2020

Platform

  • Android
  • iOS

Issue

Newly updated Sporting Event card and Flight Update card have slightly longer text. For example, instead of "San Francisco", it is "San Francisco Airport" after the update. Mobile platforms with narrower width such as Android and iOS would truncate the updated text. This is not what we want, we want to show all the text, so the ask is to add "wrap": true to those cards. Another way to fix this issue is making the "wrap" : true the default value as asked in #4483.

@jwoo-msft jwoo-msft added the Area-Samples Fixes related to our test samples label Sep 1, 2020
@jwoo-msft jwoo-msft added this to the 20.09 milestone Sep 1, 2020
@paulcam206 paulcam206 changed the title [Sample Cards] [Sample Cards] Text in sample cards truncated Sep 1, 2020
@ghost ghost added the Triage-Needed label Sep 2, 2020
@shalinijoshi19
Copy link
Member

@golddove can you take a stab at handling this? Thanks

@ghost
Copy link

ghost commented Sep 2, 2020

Hi @jwoo-msft. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19
Copy link
Member

@golddove can you take a stab at handling this? Thanks

Looks like @almedina-ms had been looking at it from his email so assigning to him instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Samples Fixes related to our test samples Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants