Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Blocks default to false for wrap #4483

Closed
anbah34 opened this issue Jul 24, 2020 · 5 comments
Closed

Text Blocks default to false for wrap #4483

anbah34 opened this issue Jul 24, 2020 · 5 comments
Assignees
Labels
Bug High Priority Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone

Comments

@anbah34
Copy link

anbah34 commented Jul 24, 2020

Platform

All Platforms. The issue is more relevant to Mobile - iOS and Android.

Author or host

Are you an author (like sending something to Outlook), or a host that is rendering your own cards? If host, please specify the corresponding host (app) name.

If you're an author, who are you sending cards to?

1.2.10

What version are you using? Ex: NuGet 1.0.2, or latest main, etc...

Details

Explain your issue. If you just have a question, please post [on StackOverflow instead

Why is it that the default value for the word wrapping is kept as false. Most times the developers test the card only on desktop and due to the large real estate the text does not get truncated but on mobile it does. I don't understand why the default value is not set to true for word wrap

MicrosoftTeams-image-31
Screen Shot 2020-07-21 at 12 34 29 PM

@anbah34 anbah34 added the Bug label Jul 24, 2020
@ghost ghost added the Triage-Needed label Jul 24, 2020
@anbah34
Copy link
Author

anbah34 commented Jul 24, 2020

@shalinijoshi19 Please see the an example of the issue that is caused with the current behavior wherin the text gets truncated unless the developer has specified word wrap to be true

cc- @VikrantSingh01

@anbah34
Copy link
Author

anbah34 commented Jul 24, 2020

FYI @matthidinger, @jwoo-msft

@RebeccaAnne RebeccaAnne changed the title [Platform][Broad Issue Category if applicable (eg Accessibility)] [Bug Title] Text Blocks default to false for wrap Jul 29, 2020
@ghost ghost removed the Triage-Needed label Jul 30, 2020
@ghost
Copy link

ghost commented Jul 30, 2020

Hi @anbah34. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@jwoo-msft jwoo-msft added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) High Priority labels Aug 26, 2020
@jwoo-msft jwoo-msft added this to the 20.09 milestone Aug 26, 2020
@jwoo-msft jwoo-msft added Design Discussion - Needed Issue requires a design discussion before proceeding and removed Design Discussion - Needed Issue requires a design discussion before proceeding labels Sep 9, 2020
@shalinijoshi19 shalinijoshi19 removed this from the 20.09 milestone Sep 21, 2020
@ghost ghost added the AdaptiveCards v20.09 label Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added this to the 20.09 milestone Sep 21, 2020
@shalinijoshi19
Copy link
Member

We'll be keeping the behavior here, but will be updating the designer instead.

@jwoo-msft
Copy link
Member

Change for updating the designer is merged. Closing it per discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug High Priority Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Development

No branches or pull requests

5 participants