Convert internal serdes from beans to ordinary classes #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
graemerocher
reviewed
Feb 7, 2024
serde-support/src/main/java/io/micronaut/serde/support/serdes/InstantSerde.java
Show resolved
Hide resolved
|
I don't see much of the improvement. But having fewer beans might help. |
yawkat
reviewed
Feb 7, 2024
serde-support/src/main/java/io/micronaut/serde/support/DefaultSerdeRegistry.java
Outdated
Show resolved
Hide resolved
|
yawkat
approved these changes
Feb 7, 2024
| .iterator(); | ||
| // pick the bean with the highest priority | ||
| final Iterator<BeanDefinition<T>> i = candidates.stream() | ||
| .sorted((bean1, bean2) -> { |
There was a problem hiding this comment.
You can use Comparator.comparingInt
| @Singleton | ||
| @Primary | ||
| @BootstrapContextCompatible | ||
| @Internal |
There was a problem hiding this comment.
Those are added as beans in LegacyBeansFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the startup.
I have extracted all of the serdes defined in the
DefaultSerdeRegistryinto own package.