Make K8s secrets watchable (#680) #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mhartmann-jaconi
force-pushed
the
6.2.x
branch
from
1ee995c
to
4461703
Compare
|
@n0tl3ss please test this feature in production k8s deployment and resolve the failing tests. Thanks. |
|
@graemerocher I have tested code it works and looks ok to me :) nice work @mhartmann-jaconi |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts common watch functionality for secrets and config-maps into abstract base classes and implement those for the dedicated sub types, so that watch config looks the same for both types and has the same base implementation.