Add executor configuration for KafkaClient #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An executor configuration parameter is added to `AbstractKafkaProducerConfiguration` and the `KafkaClient` annotation to allow an executor to be used to enable fully non-blocking reactive and `CompletableFuture` producer methods. The new configuration is used by KafkaClientIntroductionAdvice to retrieve the corresponding `ExecutorService` and use it to make the introduced method implementations non-blocking wherever possible by offloading the blocking `KafkaProducer` calls to a separate thread from that of the caller.
timyates
suggested changes
Jan 31, 2024
.../src/main/java/io/micronaut/configuration/kafka/intercept/KafkaClientIntroductionAdvice.java
Show resolved
Hide resolved
.../src/main/java/io/micronaut/configuration/kafka/intercept/KafkaClientIntroductionAdvice.java
Outdated
Show resolved
Hide resolved
...c/test/groovy/io/micronaut/configuration/kafka/annotation/KafkaClientWithExecutorSpec.groovy
Outdated
Show resolved
Hide resolved
|
|
timyates
suggested changes
Feb 8, 2024
Co-authored-by: Tim Yates <tim.yates@gmail.com>
|
timyates
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An executor configuration parameter is added to
AbstractKafkaProducerConfigurationand theKafkaClientannotation to allow an executor to be used to enable fully non-blocking reactive andCompletableFutureproducer methods.The new configuration is used by KafkaClientIntroductionAdvice to retrieve the corresponding
ExecutorServiceand use it to make the introduced method implementations non-blocking wherever possible by offloading the blockingKafkaProducercalls to a separate thread from that of the caller.Resolves #480