-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish "Grafana Dashboard" section #5662
Conversation
What do you think about deleting the whole section and doing something like this instead (probably on Grafana DashboardThere are many third-party Grafana dashboards publicly available on GrafanaHub, see an example here. NOTE: The dashboards are maintained by the community in their external GitHub repositories, so if you have an issue, it should be created in their respective GitHub repository. |
@jonatan-ivanov Thanks for the feedback! I updated as you suggested. |
@mweirauch https://grafana.com/grafana/dashboards/4701-jvm-micrometer/ doesn't seem to have a link to the GitHub repo, so you might want to add one. |
@izeye Yes, I didn't come around to do it, yet. Thanks for the heads-up! |
@izeye The README over at grafana.com has been updated. Actually took some hours for the change to take effect. |
This PR adds a note for a link to the GitHub repository for the Prometheus Grafana dashboard.
By the way, while working on this, the "Grafana Dashboard" section seems to contain a copy from the contents in the Grafana dashboard page, which is easy to get out of sync and is actually out of sync a bit already.
It might be better to remove the contents and have a link to the Grafana dashboard page only. Or if the GitHub repository has a proper README file later, it would be better to link to the README instead.
See gh-5661
/cc @mweirauch