Use failure with actual and expected message to improve IDE experience for ObservationContextAssert #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
|
Great suggestion, thank you! |
filiphr
force-pushed
the
improved-assertion-failure
branch
from
c272a35 to
412fd9c
Compare
|
Thanks @shakuzen and @marcingrzejszczak. I've also rebased this on top of main and the CircleCI is now running |
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Nov 21, 2024
shakuzen
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to improve the user experience when an assertion fails in an IDE.
e.g. the error messages prior this PR in IntelliJ look like:
After this PR they look like:
The difference is that Intellij knows how to handle the
AssertionFailedErrorand display the nice "Click to see difference" in the UI. The AssertJ library will handlefailWithActualExpectedAndMessageproperly and fallback toAssertionErrorin case theAssertionFailedErrorfrom opentest4j is not available.