Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change method signature of MultiGauge.register #5391

Merged
merged 1 commit into from
Aug 28, 2024
Merged

change method signature of MultiGauge.register #5391

merged 1 commit into from
Aug 28, 2024

Conversation

lbilger
Copy link
Contributor

@lbilger lbilger commented Aug 15, 2024

change method signature of MultiGauge.register to also allow e.g. List<Row> as a parameter

fixes #5390

shakuzen
shakuzen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. This sounds reasonable to me. The only concern is backward compatibility, but this looks like it should be backward compatible.

@shakuzen shakuzen merged commit 5cf7222 into micrometer-metrics:main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiGauge.register should accept more types
2 participants
@lbilger @shakuzen