Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build job on JDK 11 #2756

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Add a build job on JDK 11 #2756

merged 1 commit into from
Aug 20, 2021

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Aug 18, 2021

This is similar to #2480, but for JDK 11.

See gh-2480
See gh-2755

@izeye
Copy link
Contributor Author

izeye commented Aug 18, 2021

The build on JDK 11 is expected to fail, but it has passed due to the build cache as follows:

...
> Task :micrometer-core:compileJava FROM-CACHE
...

See https://app.circleci.com/pipelines/github/izeye/micrometer/739/workflows/69ef6975-c18a-4ac8-aee3-ec490f8d24c2/jobs/1316

@jonatan-ivanov
Copy link
Member

This is weird, that task must have missed the cache because of the different JDK version.

@shakuzen shakuzen added build A change in our build-system type: task A general task labels Aug 20, 2021
@shakuzen shakuzen added this to the 1.6.11 milestone Aug 20, 2021
@shakuzen shakuzen merged commit 8d819c6 into micrometer-metrics:1.5.x Aug 20, 2021
@izeye izeye deleted the jdk11 branch August 20, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build A change in our build-system type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants