Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jetty handshake metrics binding #1975

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Add Jetty handshake metrics binding #1975

merged 3 commits into from
Apr 23, 2020

Conversation

john-karp
Copy link
Contributor

Add a Jetty binding to record the TLS version and ciphersuite used for new TLS connections, along with handshake failures.

@shakuzen shakuzen added the enhancement A general enhancement label Apr 23, 2020
@shakuzen shakuzen added this to the 1.5.0 milestone Apr 23, 2020
shakuzen
shakuzen approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@shakuzen shakuzen merged commit cad1d9b into micrometer-metrics:master Apr 23, 2020
@john-karp john-karp deleted the jetty-handshake branch April 23, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@john-karp @shakuzen