Fido: Supplement missing processing #3031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey is created based on the existing code.
…ix_fido_passkey_sign_in
mar-v-in
reviewed
Sep 29, 2025
Comment on lines
+220
to
223
| // Default: SHA-256 | ||
| val digest = context.packageManager.getFirstSignatureDigest(packageName, "SHA-256") | ||
| ?: throw RequestHandlingException(NOT_ALLOWED_ERR, "Unknown package $packageName") | ||
| return "android:apk-key-hash:${digest.toBase64(HASH_BASE64_FLAGS)}" |
There was a problem hiding this comment.
This seems wrong. It should be either android:apk-key-hash:<sha-1> or android:apk-key-hash-sha256:<sha-256>, but not a mix.
There was a problem hiding this comment.
I also noticed this, but in the fido specification, the pr server recognizes SHA-256
| "android:apk-key-hash:${firstSignature.digest("SHA1").toBase64(HASH_BASE64_FLAGS)}" | ||
| } | ||
| "android:apk-key-hash:$sha1BASE64" -> "android:apk-key-hash-sha256:$sha256BASE64" | ||
| "android:apk-key-hash:$sha256BASE64" -> "android:apk-key-hash-sha256:$sha256BASE64" |
There was a problem hiding this comment.
And you need this here, because you wrongly created it above.
There was a problem hiding this comment.
Removed sha-1 related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing parameters.
Fix the failure of third-party application verification key. Contains: Fido: fix support for discoverable keys #2885
Fixed the issue that the created key cannot be used, and the latest key is created based on the existing code.
Implement multiple passkey switching logins. Similar logic to FIDO: Add credential selection #2463 & Contains: SignIn: Avoid error messages #3000