Updated test suite #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed reference to PHP 5.3 now that PHP 5.4 is a minimum requirement.
|
@aaronpk @dissolve @barnabywalters and anyone else: if you have time would you mind reviewing this PR? I'd like to get this set of three PRs merged so I can work on further improvements. |
|
Can you commit the updated |
|
Ok, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test suite to be included via Composer so we can more easily keep it up to date with https://github.com/microformats/tests, per #50.
The comparison of parsed mf2 to expected output now compares the complete array, not just the 'items' key. I took a stab at better array comparison, since the === comparison expects the array indexes to be in the same order.
Unfortunately these changes bring the number of passing tests to zero, but hopefully a lot of those are minor. For example, I know that php-mf2 puts the "T" separator in parsed dt- values, but the test suite expected output does not (see discussion), so most date values will have that discrepancy.
The updated array comparison should verify that every value in the expected output appears in the parsed output, but does not account for the parsed output having more than the expected output. The array comparison could be run twice (switching the array parameters) but I wasn't sure if that was desired. And I thought it was more important to make sure the parser returns at least the expected output.