Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP5.6 #220

Merged
merged 8 commits into from
May 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
dist: trusty
language: php
php:
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
- 7.4
- nightly
env:
- COMPOSER_REQUIRE=""
Expand All @@ -17,5 +16,5 @@ matrix:
allow_failures:
- php: nightly
install:
- composer update
- $COMPOSER_REQUIRE
before_script: composer install
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,14 @@ Pull requests very welcome, please try to maintain stylistic, structural and nam

1. Fork the repo to your github account
2. Clone a copy to your computer (simply installing php-mf2 using composer only works for using it, not developing it)
3. Install the dev dependencies with `./composer.phar install`
4. Run PHPUnit with `./vendor/bin/phpunit`
5. Make your changes
3. Install the dev dependencies with `composer install`.
4. Run PHPUnit with `composer phpunit`
5. Check PHP Compatibility with the current minimum version supported (`composer phpcs`)
6. Add PHPUnit tests for your changes, either in an existing test file if suitable, or a new one
7. Make sure your tests pass (`./vendor/bin/phpunit`), using 5.4+
8. Go to your fork of the repo on github.com and make a pull request, preferably with a short summary, detailed description and references to issues/parsing specs as appropriate
9. Bask in the warm feeling of having contributed to a piece of free software
7. Make your changes
8. Make sure your tests pass (`composer phpunit`)
9. Go to your fork of the repo on github.com and make a pull request, preferably with a short summary, detailed description and references to issues/parsing specs as appropriate
10. Bask in the warm feeling of having contributed to a piece of free software

### Testing

Expand Down
19 changes: 16 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,26 @@
],
"bin": ["bin/fetch-mf2", "bin/parse-mf2"],
"require": {
"php": ">=5.4.0"
"php": ">=5.6.0"
},
"config": {
"platform": {
}
},
"require-dev": {
"phpunit/phpunit": "4.8.*",
"phpdocumentor/phpdocumentor": "v2.8.4",
"mf2/tests": "@dev"
"mf2/tests": "@dev",
"squizlabs/php_codesniffer": "^2.6 || ^3.1.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.6",
"phpcompatibility/php-compatibility": "^9.3"
},
"scripts": {
"install-codestandards": [
"Dealerdirect\\Composer\\Plugin\\Installers\\PHPCodeSniffer\\Plugin::run"
],
"phpcs": "./vendor/bin/phpcs -p",
"phpunit": "./vendor/bin/phpunit"
},
"autoload": {
"files": ["Mf2/Parser.php"]
},
Expand Down
Loading