Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mf2/tests test suite with PHPUnit during default testing #163

Merged
merged 17 commits into from
Jun 13, 2020

Commits on May 27, 2020

  1. Configuration menu
    Copy the full SHA
    16c2595 View commit details
    Browse the repository at this point in the history
  2. Remove outdated test data

    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    2d026e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b8cc617 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9d589a View commit details
    Browse the repository at this point in the history
  5. Better display of test name

    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    8025feb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d36841c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc2ee57 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    236e2d9 View commit details
    Browse the repository at this point in the history
  9. Remove consecutive whitespace when comparing tests

    As discussed previously php-mf2 has custom handling of textContent to
    match with what consumers were expecting to get back. This means all
    tests around plain text output have a high tendency to fail.
    
    This change addresses that a little by ignoring whitespace differences
    within e-* properties.
    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    18bb4cf View commit details
    Browse the repository at this point in the history
  10. Point at latest test suite

    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    578ad39 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4d46586 View commit details
    Browse the repository at this point in the history
  12. Rename Parser to TestSuiteParser

    Travis was showing weird errors in PHP versions before 7.0 about
    duplicate name usage. Weird because the Parser class defined for
    the test should live in a completely separate namespace.
    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    fb6d089 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    79eb0a5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bbda674 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    727a299 View commit details
    Browse the repository at this point in the history
  16. Make Travis run all mf2 tests

    We mark a single test as incomplete (ie. unimplemented) because the
    parser implements a proposed extension to the mf2 specification while
    the test suite has tests that exactly match the specification.
    Zegnat committed May 27, 2020
    Configuration menu
    Copy the full SHA
    784b6a6 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Define an option so loadHTML does not drop whitespace

    Certain builds of PHP seem to drop specific whitespace during the HTML
    parsing step. There seems to be no reason for this and the behaviour
    has been seen for versions of PHP ranging all the way from 5.6 to 7.3.
    The behaviour seems to be sidestepped by providing any supported
    parsing option to the loadHTML method. LIBXML_NOWARNING was chosen as
    it seemed like it would have the least impact overall.
    
    For a PHP test to surface the behaviour, as well as the test of the
    effect of constants please see:
    https://gist.github.com/Zegnat/a94489e9b7d5501193e724e336bc6052
    
    Huge thanks to everyone in #indieweb-dev who went on this journey with
    me! Especially @cweiske and @Lewiscowles1986 for all the extra
    testing, and @gRegorLove for getting the ball rolling with
    parsing options.
    Zegnat committed May 30, 2020
    Configuration menu
    Copy the full SHA
    3b68bc5 View commit details
    Browse the repository at this point in the history