-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run mf2/tests test suite with PHPUnit during default testing #163
Merged
Commits on May 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 16c2595 - Browse repository at this point
Copy the full SHA 16c2595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d026e5 - Browse repository at this point
Copy the full SHA 2d026e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8cc617 - Browse repository at this point
Copy the full SHA b8cc617View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d589a - Browse repository at this point
Copy the full SHA a9d589aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8025feb - Browse repository at this point
Copy the full SHA 8025febView commit details -
Configuration menu - View commit details
-
Copy full SHA for d36841c - Browse repository at this point
Copy the full SHA d36841cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2ee57 - Browse repository at this point
Copy the full SHA cc2ee57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 236e2d9 - Browse repository at this point
Copy the full SHA 236e2d9View commit details -
Remove consecutive whitespace when comparing tests
As discussed previously php-mf2 has custom handling of textContent to match with what consumers were expecting to get back. This means all tests around plain text output have a high tendency to fail. This change addresses that a little by ignoring whitespace differences within e-* properties.
Configuration menu - View commit details
-
Copy full SHA for 18bb4cf - Browse repository at this point
Copy the full SHA 18bb4cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 578ad39 - Browse repository at this point
Copy the full SHA 578ad39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d46586 - Browse repository at this point
Copy the full SHA 4d46586View commit details -
Rename Parser to TestSuiteParser
Travis was showing weird errors in PHP versions before 7.0 about duplicate name usage. Weird because the Parser class defined for the test should live in a completely separate namespace.
Configuration menu - View commit details
-
Copy full SHA for fb6d089 - Browse repository at this point
Copy the full SHA fb6d089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79eb0a5 - Browse repository at this point
Copy the full SHA 79eb0a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbda674 - Browse repository at this point
Copy the full SHA bbda674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 727a299 - Browse repository at this point
Copy the full SHA 727a299View commit details -
We mark a single test as incomplete (ie. unimplemented) because the parser implements a proposed extension to the mf2 specification while the test suite has tests that exactly match the specification.
Configuration menu - View commit details
-
Copy full SHA for 784b6a6 - Browse repository at this point
Copy the full SHA 784b6a6View commit details
Commits on May 30, 2020
-
Define an option so loadHTML does not drop whitespace
Certain builds of PHP seem to drop specific whitespace during the HTML parsing step. There seems to be no reason for this and the behaviour has been seen for versions of PHP ranging all the way from 5.6 to 7.3. The behaviour seems to be sidestepped by providing any supported parsing option to the loadHTML method. LIBXML_NOWARNING was chosen as it seemed like it would have the least impact overall. For a PHP test to surface the behaviour, as well as the test of the effect of constants please see: https://gist.github.com/Zegnat/a94489e9b7d5501193e724e336bc6052 Huge thanks to everyone in #indieweb-dev who went on this journey with me! Especially @cweiske and @Lewiscowles1986 for all the extra testing, and @gRegorLove for getting the ball rolling with parsing options.
Configuration menu - View commit details
-
Copy full SHA for 3b68bc5 - Browse repository at this point
Copy the full SHA 3b68bc5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.