Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI enforce code format #128

Merged
merged 4 commits into from
Jul 17, 2021
Merged

CI enforce code format #128

merged 4 commits into from
Jul 17, 2021

Conversation

6543
Copy link
Contributor

@6543 6543 commented Jul 8, 2021

  • enforce CI to only allow formatted code
  • add make target to check code format
  • format code

6543
6543 commented Jul 8, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@6543 6543 changed the title CI enforce code format WIP: CI enforce code format Jul 8, 2021
@6543 6543 force-pushed the ci-enforce-code-format branch 3 times, most recently from 92893e7 to 6d0fd3f Compare July 9, 2021 01:43
@6543 6543 changed the title WIP: CI enforce code format CI enforce code format Jul 9, 2021
@6543
Copy link
Contributor Author

6543 commented Jul 9, 2021

@buro9 now only add one task more finishing in in 4s so it should not be a big deal for CI to add but a nice improvement for added code ;)

@6543 6543 force-pushed the ci-enforce-code-format branch from 6d0fd3f to be04ac9 Compare July 13, 2021 15:11
@6543
Copy link
Contributor Author

6543 commented Jul 13, 2021

@buro9 ci failed unrelated can you restart it?

@grafana-dee
Copy link
Contributor

@buro9 ci failed unrelated can you restart it?

Done 👍

@6543
Copy link
Contributor Author

6543 commented Jul 17, 2021

@buro9 I think it is ready :)

grafana-dee
grafana-dee suggested changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@grafana-dee grafana-dee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If surplus files are removed, I'd merge :)

.github/workflows/test.yml Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
.gitattributes Show resolved Hide resolved
@grafana-dee grafana-dee merged commit cada0f0 into microcosm-cc:master Jul 17, 2021
@6543 6543 deleted the ci-enforce-code-format branch July 17, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafana-dee grafana-dee grafana-dee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @grafana-dee