-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ファイルの利用方法の案内の整備 #78
ファイルの利用方法の案内の整備 #78
Conversation
WalkthroughThe recent update enriches the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedLanguageTool (21)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
README.md (3)
Line range hint
101-101
: Start sentences with an uppercase letter.The sentence "And, Api corresponding to each content are also available. example." should start with an uppercase letter for "Api" and "example".
- And, Api corresponding to each content are also available. example. + And, API corresponding to each content are also available. Example:
Line range hint
130-130
: Use consistent capitalization for abbreviations.The word "ids" in "Get all content ids" should be capitalized to "IDs" for consistency and to match the common abbreviation style.
- #### Get all content ids + #### Get all content IDs
Line range hint
382-382
: Add a comma for clarity.In the sentence "Please refer to the official Next.js documentation as the available options depend on the Next.js Type file.", adding a comma after "documentation" would improve readability.
- Please refer to the official Next.js documentation as the available options depend on the Next.js Type file. + Please refer to the official Next.js documentation, as the available options depend on the Next.js Type file.
README.md
Outdated
Please load and use the URL provided by an external provider. | ||
|
||
```html | ||
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk@3.1.0/dist/umd/microcms-js-sdk.min.js"></script> | ||
|
||
or | ||
|
||
<script src="https://unpkg.com/microcms-js-sdk@latest/dist/umd/microcms-js-sdk.js"></script> | ||
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk/dist/umd/microcms-js-sdk.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update CDN links to reflect the new provider.
The documentation section for CDN usage still references unpkg.com
in the warning message at lines 46-47, which is inconsistent with the switch to jsDelivr. Update the warning to reflect the new CDN provider or adjust the message to be more generic about third-party hosting risks.
- > The hosting service (unpkg.com) is not related to microCMS. For production use, we recommend self-hosting on your own server.
+ > Be cautious when using third-party hosting services for production. We recommend self-hosting on your own server or using a trusted CDN provider.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Please load and use the URL provided by an external provider. | |
```html | |
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk@3.1.0/dist/umd/microcms-js-sdk.min.js"></script> | |
or | |
<script src="https://unpkg.com/microcms-js-sdk@latest/dist/umd/microcms-js-sdk.js"></script> | |
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk/dist/umd/microcms-js-sdk.min.js"></script> | |
Please load and use the URL provided by an external provider. | |
```html | |
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk@3.1.0/dist/umd/microcms-js-sdk.min.js"></script> | |
or | |
<script src="https://cdn.jsdelivr.net/npm/microcms-js-sdk/dist/umd/microcms-js-sdk.min.js"></script> |
Be cautious when using third-party hosting services for production. We recommend self-hosting on your own server or using a trusted CDN provider.
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応ありがとうございます!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
README.md (2)
Line range hint
101-101
: Capitalize the first letter of the sentence for proper grammar.- And, Api corresponding to each content are also available. example. + And, API corresponding to each content are also available. Example:
Line range hint
130-130
: Ensure consistent spelling of "IDs" in all uppercase.- #### Get all content ids + #### Get all content IDs
``` | ||
|
||
> [!WARNING] | ||
> The hosting service (unpkg.com) is not related to microCMS. For production use, we recommend self-hosting on your own server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the warning message to reflect the new CDN provider or make it generic.
- > The hosting service (unpkg.com) is not related to microCMS. For production use, we recommend self-hosting on your own server.
+ > Be cautious when using third-party hosting services for production. We recommend self-hosting on your own server or using a trusted CDN provider.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
> The hosting service (unpkg.com) is not related to microCMS. For production use, we recommend self-hosting on your own server. | |
> Be cautious when using third-party hosting services for production. We recommend self-hosting on your own server or using a trusted CDN provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応ありがとうございます!
Summary by CodeRabbit
microcms-js-sdk
package, specifying Node.js version requirements.