Skip to content

Commit

Permalink
upy-fs-builder: Remove addIntelHexFile() and improve tests.
Browse files Browse the repository at this point in the history 
Having addIntelHexFiles() makes addIntelHexFile() unnecesary and
now all the tests target the same entry point function.

Tests now also check for specific error messages, instead of just
any error.
  • Loading branch information
@microbit-carlos
microbit-carlos committed May 11, 2020
1 parent f0502fe commit 9738a5b
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 81 deletions.
110 changes: 55 additions & 55 deletions src/__tests__/micropython-fs-builder.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ import * as fs from 'fs';

import MemoryMap from 'nrf-intel-hex';

import { bytesToStr, strToBytes } from '../common';
import { strToBytes } from '../common';
import {
addIntelHexFile,
addIntelHexFiles,
calculateFileSize,
getIntelHexFiles,
Expand Down Expand Up @@ -286,12 +285,10 @@ describe('Writing files to the filesystem.', () => {
},
};

it('Can generate a full chunk that also uses the next one.', () => {
const fwWithFsOther = addIntelHexFile(
uPyHexFile,
fullChunkPlus.fileName,
strToBytes(fullChunkPlus.fileStr)
);
it('Can generate a full chunk that also consumes the next one.', () => {
const fwWithFsOther = addIntelHexFiles(uPyHexFile, {
[fullChunkPlus.fileName]: strToBytes(fullChunkPlus.fileStr),
});

const opMap = MemoryMap.fromHex(fwWithFsOther);
const readFileData = opMap
Expand All @@ -301,11 +298,9 @@ describe('Writing files to the filesystem.', () => {
});

it('Correctly generate an almost full chunk (not using last byte).', () => {
const fwWithFsOther = addIntelHexFile(
uPyHexFile,
fullChunkMinus.fileName,
strToBytes(fullChunkMinus.fileStr)
);
const fwWithFsOther = addIntelHexFiles(uPyHexFile, {
[fullChunkMinus.fileName]: strToBytes(fullChunkMinus.fileStr),
});

const opMap = MemoryMap.fromHex(fwWithFsOther);
const readFileData = opMap
Expand All @@ -314,12 +309,10 @@ describe('Writing files to the filesystem.', () => {
expect(readFileData).toEqual(fullChunkMinus.bytes());
});

it('Correctlty generate just over a full chunk.', () => {
const fwWithFsOther = addIntelHexFile(
uPyHexFile,
twoChunks.fileName,
strToBytes(twoChunks.fileStr)
);
it('Correctly generate just over a full chunk.', () => {
const fwWithFsOther = addIntelHexFiles(uPyHexFile, {
[twoChunks.fileName]: strToBytes(twoChunks.fileStr),
});

const opMap = MemoryMap.fromHex(fwWithFsOther);
const readFileData = opMap
Expand All @@ -329,31 +322,25 @@ describe('Writing files to the filesystem.', () => {
});

it('Empty file name throws an error.', () => {
const failCase = () => addIntelHexFile(uPyHexFile, '', randContent);
const failCase = () => addIntelHexFiles(uPyHexFile, { '': randContent });

expect(failCase).toThrow(Error);
expect(failCase).toThrow('File has to have a file name');
});

it('Empty file data throw an error.', () => {
const failCase = () => {
const hexWithFs = addIntelHexFile(
uPyHexFile,
'my_file.txt',
new Uint8Array(0)
);
};
expect(failCase).toThrow(Error);
const failCase = () =>
addIntelHexFiles(uPyHexFile, { 'my_file.txt': new Uint8Array(0) });

expect(failCase).toThrow('has to contain data');
});

it('Large file that does not fit throws error.', () => {
const failCase = () => {
const hexWithFs = addIntelHexFile(
uPyHexFile,
'my_file.txt',
new Uint8Array(50 * 1024).fill(0x55)
);
addIntelHexFiles(uPyHexFile, {
'my_file.txt': new Uint8Array(50 * 1024).fill(0x55),
});
};
expect(failCase).toThrow(Error);
expect(failCase).toThrow('Not enough space');
});

it('Add files until no more fit.', () => {
Expand All @@ -362,36 +349,49 @@ describe('Writing files to the filesystem.', () => {
// Use 4 KB blocks per file (each chunk is 128 B)
const fakeBigFileData = new Uint8Array(4000).fill(0x55);
const fakeSingleChunkData = new Uint8Array([0x55, 0x55]);

const addLargeFiles = () => {
// At 4Kbs we only fit 7 files
for (let i = 0; i < 15; i++) {
hexWithFs = addIntelHexFile(
hexWithFs,
'file_' + i + '.txt',
fakeBigFileData
);
hexWithFs = addIntelHexFiles(hexWithFs, {
['file_' + i + '.txt']: fakeBigFileData,
}) as string;
}
};
const completeFsFilling = () => {
// At a maximum of 4 Kbs left, it would fit 32 chunks max
for (let i = 100; i < 132; i++) {
hexWithFs = addIntelHexFile(
hexWithFs,
'file_' + i + '.txt',
fakeSingleChunkData
);
hexWithFs = addIntelHexFiles(hexWithFs, {
['file_' + i + '.txt']: fakeSingleChunkData,
}) as string;
}
};
expect(addLargeFiles).toThrow(Error);
expect(completeFsFilling).toThrow(Error);

expect(addLargeFiles).toThrow('Not enough space');
expect(completeFsFilling).toThrow('no storage space left');
});

it('Add a group of files that do not fit.', () => {
// The MicroPython hex has about 29 KBs
const hexWithFs = uPyHexFile;
// Use 4 KB blocks per file (each chunk is 128 B)
const fakeBigFileData = new Uint8Array(4000).fill(0x55);
const tooManyBigFiles: { [filename: string]: Uint8Array } = {};
for (let i = 0; i < 8; i++) {
tooManyBigFiles['file_' + i + '.txt'] = fakeBigFileData;
}

const addingAllFiles = () => addIntelHexFiles(uPyHexFile, tooManyBigFiles);

expect(addingAllFiles).toThrow('Not enough space');
});

it('Max filename length works.', () => {
const maxLength = 120;
const largeName = 'a'.repeat(maxLength);

const workingCase = () =>
addIntelHexFile(uPyHexFile, largeName, randContent);
addIntelHexFiles(uPyHexFile, { [largeName]: randContent });

expect(workingCase).not.toThrow(Error);
});
Expand All @@ -400,20 +400,20 @@ describe('Writing files to the filesystem.', () => {
const maxLength = 120;
const largeName = 'a'.repeat(maxLength + 1);

const failCase = () => addIntelHexFile(uPyHexFile, largeName, randContent);
const failCase = () =>
addIntelHexFiles(uPyHexFile, { [largeName]: randContent });

expect(failCase).toThrow(Error);
expect(failCase).toThrow('File name');
});

it('Adding files to non-MicroPython hex fails.', () => {
const failCase = () =>
addIntelHexFile(makecodeHexFile, 'a.py', randContent);
addIntelHexFiles(makecodeHexFile, { 'a.py': randContent });

expect(failCase).toThrow(Error);
expect(failCase).toThrow('Could not find valid MicroPython UICR');
});

// TODO: Hex file with persistent page marker doesn't get two markers
// TODO: Hex file with injection string (:::...) still works
});

describe('Reading files from the filesystem.', () => {
Expand Down Expand Up @@ -704,7 +704,7 @@ describe('Reading files from the filesystem.', () => {

const failCase = () => getIntelHexFiles(fullUpyFsMemMap.asHexString());

expect(failCase).toThrow(Error);
expect(failCase).toThrow('Found multiple files named');
});

it('Reading files from empty MicroPython hex returns empty list.', () => {
Expand All @@ -716,7 +716,7 @@ describe('Reading files from the filesystem.', () => {
it('Reading files from non-MicroPython hex fails.', () => {
const failCase = () => getIntelHexFiles(makecodeHexFile);

expect(failCase).toThrow(Error);
expect(failCase).toThrow('Could not find valid MicroPython UICR');
});

// TODO: Read tests with a file that has chunks in non-continuous order
Expand Down
27 changes: 1 addition & 26 deletions src/micropython-fs-builder.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -344,36 +344,12 @@ function addMemMapFile(
return intelHexMap;
}

/**
* Adds a byte array as a file in the MicroPython filesystem.
*
* @throws {Error} When the invalid file name is given.
* @throws {Error} When the the file doesn't have any data.
* @throws {Error} When there are issues calculating the file system boundaries.
* @throws {Error} When there is no space left for the file.
*
* @param intelHex - MicroPython Intel Hex string.
* @param filename - Name for the file.
* @param data - Byte array for the file data.
* @returns MicroPython Intel Hex string with the file in the filesystem.
*/
function addIntelHexFile(
intelHex: string,
filename: string,
data: Uint8Array
): string {
// filename and data checked in addMemMapFile
let intelHexMap: MemoryMap = MemoryMap.fromHex(intelHex);
intelHexMap = addMemMapFile(intelHexMap, filename, data);
return intelHexMap.asHexString() + '\n';
}

/**
* Adds a hash table of filenames and byte arrays as files to the MicroPython
* filesystem.
*
* @throws {Error} When the an invalid file name is given.
* @throws {Error} When the a file doesn't have any data.
* @throws {Error} When a file doesn't have any data.
* @throws {Error} When there are issues calculating the file system boundaries.
* @throws {Error} When there is no space left for a file.
*
Expand Down Expand Up @@ -518,7 +494,6 @@ function getIntelHexFsSize(intelHex: string): number {
}

export {
addIntelHexFile,
addIntelHexFiles,
calculateFileSize,
getIntelHexFiles,
Expand Down

0 comments on commit 9738a5b

Please sign in to comment.