Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for spaces in variable names #650

Merged
merged 17 commits into from
Nov 1, 2024
Merged

Conversation

TuomasBorman
Copy link
Contributor

I noticed that formula creation in dbRDA can lead to an error when variable names have spaces. Now it is ensured that, the formula works with spaces.

Moreover, meltSE replaced spaces with dots. Now the data is melted so that variable names are kept untouched.

@TuomasBorman
Copy link
Contributor Author

In theory, the formula shoudl work. However, in here microbiome/miaViz#156, there are problems in facetting and formula formatting. Check that everything works.

@TuomasBorman TuomasBorman marked this pull request as draft October 22, 2024 13:42
R/meltAssay.R Outdated Show resolved Hide resolved
@TuomasBorman
Copy link
Contributor Author

In theory, the formula shoudl work. However, in here microbiome/miaViz#156, there are problems in facetting and formula formatting. Check that everything works.

It seems that the problem in miaViz was related to different thing. I will still keep this as a draft since checks are failing.

@TuomasBorman TuomasBorman marked this pull request as ready for review October 29, 2024 15:56
@TuomasBorman
Copy link
Contributor Author

I confirm that everything works now

@TuomasBorman TuomasBorman merged commit 817f324 into devel Nov 1, 2024
2 of 3 checks passed
@TuomasBorman TuomasBorman deleted the var_spaces branch November 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant