Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename getTop*, getPrevalent*, getUnique* and get Rare* functions #526

Merged
merged 13 commits into from
May 20, 2024
Merged

Rename getTop*, getPrevalent*, getUnique* and get Rare* functions #526

merged 13 commits into from
May 20, 2024

Conversation

thpral
Copy link
Collaborator

@thpral thpral commented Apr 22, 2024

This PR makes the following naming modifications :

  • getRareFeatures --> getRare

  • getRareTaxa --> getRare

  • getTopFeatures --> getTop

  • getTopTaxa --> getTop

  • getPrevalentFeatures --> getPrevalent

  • getPrevalentTaxa --> getPrevalent

  • getUniqueFeatures --> getUnique

  • getUniqueTaxa --> getUnique

This was referenced Apr 22, 2024
Merged
Merged
thpral added 2 commits April 25, 2024 13:41
@thpral
merge devel
ef55164 
Merge branch 'devel' of https://github.com/microbiome/mia into rename_getters

# Conflicts:
#	NEWS
#	R/deprecate.R
#	man/deprecate.Rd
@thpral
fix deprecate doc
c8a5cc7
thpral and others added 6 commits May 6, 2024 13:54
@thpral
merge devel
27928de 
Merge branch 'devel' of https://github.com/microbiome/mia into rename_getters

# Conflicts:
#	NEWS
#	pkgdown/_pkgdown.yml
@thpral
Merge branch 'devel' into rename_getters
1cc03d2
@TuomasBorman
sync
ecfbdac 
Sync

# Conflicts:
#	DESCRIPTION
#	NEWS
#	R/deprecate.R
#	R/getPrevalence.R
#	man/deprecate.Rd
#	man/getPrevalence.Rd
#	man/summaries.Rd
#	tests/testthat/test-5prevalence.R
#	tests/testthat/test-8summaries.R
@TuomasBorman
up
5fc5f8b
@TuomasBorman
up
c6886e4
@TuomasBorman
up
a504b9c
@TuomasBorman TuomasBorman merged commit 0d264b8 into devel May 20, 2024
3 checks passed
@TuomasBorman TuomasBorman deleted the rename_getters branch May 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuomasBorman TuomasBorman TuomasBorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thpral @TuomasBorman