Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unicode-width #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

extrawurst
Copy link

No description provided.

@micl2e2
Copy link
Owner

micl2e2 commented Oct 23, 2024

Thanks for the reminder!

It seems like the recent updates of unicode-width have introduced some compatibility issues to downstreams like us. Several tests in this crate would fail even with a minor version change (to 0.13.0). By indicating ^0.1.0 in our cargo file, we already assumed that we'd be totally fine with any possible updates as long as they follow the semver convention so that our crate remains consistent. Unfortunately, the major version for the latest one 0.2.0 is still unchanged, which means it is uncertain whether there would be similar changes being introduced in its future updates.

But something for bwrap is already certain: if any breaking changes are introduced, our crate's major version will move forward, that say, the next update will be either locking unicode-width's version to the original one, or bumping the major version to 2. I am still trying to figure out the actual benefits that we could gain from unicode-width's recent updates, and will take action after evaluating the tradeoff.

@extrawurst
Copy link
Author

@micl2e2 how do you want to move forward with this?

@micl2e2
Copy link
Owner

micl2e2 commented Jan 11, 2025

The current code has been working fine since their previous fix (unicode-rs/unicode-width#67). The changes in 0.2 fails more half of our tests, would require significant changes to the algorithm. Currently I just don't have time for any extra new feature implementing for this crate so, unless all tests being passed, the unicode-width might stay 0.1.x for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants