Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not create a command prompt window when running wsl.exe #1

Merged
merged 5 commits into from
Oct 20, 2024
Merged

fix: Do not create a command prompt window when running wsl.exe #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15c4330
fix: Do not create a command prompt window when running `wsl.exe`
Holzhaus Jan 11, 2024
f781f19
Merge branch 'develop' into create-no-window
michidk Oct 20, 2024
a024687
Fix fmt
michidk Oct 20, 2024
13d604d
fix fmt
michidk Oct 20, 2024
190c03c
Update lib.rs
michidk Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@

use std::process::Command;

#[cfg(windows)]
use std::os::windows::process::CommandExt;

/// Type of conversion to perform
#[derive(Debug)]
pub enum Conversion {
Expand Down Expand Up @@ -71,18 +74,30 @@ pub fn convert(
args.push("-a");
}

let cmd = Command::new("wsl.exe")
.args(args)
.arg(path.replace('\\', "\\\\"))
let mut cmd = Command::new("wsl.exe");
cmd.args(args);
cmd.arg(path.replace('\\', "\\\\"));

// Disable window creation on Windows
//
// This is necessary to prevent a command prompt window from being shown for a short time,
// which is likely undesired, especially for GUI applications.
//
// The flags are documented here:
// https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags#flags
#[cfg(windows)]
cmd.creation_flags(0x08000000); // CREATE_NO_WINDOW

let output = cmd
.output()
.map_err(|e| format!("Error executing wsl.exe: {}", e))?;

let code = cmd.status.code().unwrap_or(-1);
let code = output.status.code().unwrap_or(-1);
if code != 0 {
return Err(format!("Error getting wslpath: {}", code).into());
}

Ok(std::str::from_utf8(&cmd.stdout)
Ok(std::str::from_utf8(&output.stdout)
.map_err(|e| format!("Error converting output to string: {}", e))?
.trim()
.to_string())
Expand Down
Loading