-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to specify list for entry node file #147
Conversation
1 similar comment
I'm closing this since we haven't received feedback from the author of the code that is changed @ephys |
Oh, hello The only drawback I would see is if you want the node entry point to be bundable (some people bundle their node code to reduce startup time) |
@ephys do you think this will work in browser environments? I'm not familiar using npm in frontend projects... |
@michaelwittig With this PR, this specific file would not work in browser environments anymore, but that shouldn't be an issue because |
This reverts commit 96d38e0.
I had to revert this change because of #212 |
No need to specify the languages list for entry node file for easier further maintain and reduce possible mismatch here.