Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table row without closing tag no longer rendered correctly #494

Closed
howff opened this issue Sep 29, 2022 · 7 comments
Closed

Table row without closing tag no longer rendered correctly #494

howff opened this issue Sep 29, 2022 · 7 comments
Assignees
@michaelrsweet
Labels
bug Something isn't working priority-low
Milestone
Stable

Comments

@howff
Copy link

howff commented Sep 29, 2022

HTML table rows without a closing tag </tr> are no longer rendered correctly.
I tried with --no-strict but it made no difference.
No dangling errors are reported with --strict anyway.
Previous versions of htmldoc worked fine.
@michaelrsweet
Copy link
Owner

What version of HTMLDOC did you use previously?

@michaelrsweet michaelrsweet self-assigned this Sep 29, 2022
@michaelrsweet michaelrsweet added the investigating Investigating the issue label Sep 29, 2022
@howff
Copy link
Author

howff commented Sep 30, 2022

Sorry the machine I used to use has been wiped so I can't find out which version but it's safe to say it would have been several years ago (possibly 2014-2016).

@michaelrsweet
Copy link
Owner

Ok well please provide a sample html file that isn’t converting properly and I’ll look at it.

@howff
Copy link
Author

howff commented Sep 30, 2022

Here's two tables, one works and the other doesn't

<html><head><title>Title</title></head><body>
		<h1>Table is rendered incorrectly</h1>
		<table>
			<tr>
				<th>Heading 1
				<th>Heading 2
			<tr>
				<td>Col 1
				<td>Col 2
		</table>
		<h1>Table is OK because &lt;/tr&gt;</h1>
		<table>
			<tr>
				<th>Heading 1
				<th>Heading 2
			</tr>
			<tr>
				<td>Col 1
				<td>Col 2
			</tr>
		</table>
	</body>
</html>

@michaelrsweet
Copy link
Owner

michaelrsweet commented Oct 10, 2022 •
edited
Loading

OK, thanks I've reproduced the issue. This might have changed between some 1.8.x release and the current one - might be a regression from a fix (2c47d1f) I made a little over 4 years ago,

@michaelrsweet michaelrsweet added bug Something isn't working priority-low and removed investigating Investigating the issue labels Oct 10, 2022
@michaelrsweet michaelrsweet added this to the Stable milestone Oct 10, 2022
michaelrsweet added a commit that referenced this issue Feb 11, 2024
@michaelrsweet
Fix handling of missing close TRs (Issue #494)
c897072
@michaelrsweet
Copy link
Owner

[master c897072] Fix handling of missing close TRs (Issue #494)

@howff
Copy link
Author

howff commented Feb 11, 2024

Thanks very much :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working priority-low
Projects
None yet
Milestone
Stable
Development

No branches or pull requests
2 participants
@michaelrsweet @howff